-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: GL-11: Adding provenance/attribution from ESM tools #34
base: main
Are you sure you want to change the base?
Conversation
Hi @LuiggiTenorioK, I'm happy to help with this. When you say tomorrow meeting, do you mean the 23rd of October? I could have time for a meeting indeed. What time would it work for you? |
Hi Miguel! Sorry the confusion. We migrated the code from GitLab to GitHub, and the person running the import process becomes the OP of every issue and pull request. What happened here is that @LuiggiTenorioK ran the tool, and it looks like he's commenting, but the comment above was mine, from the week of the hackathon 🙂 We can discuss about it later, but for now we are just moving things around. Sorry for the spam! One repo migrated, over next days will migrate GUI and API, and in December when it's quieter we will handle Autosubmit... then it will be time for the great automation work to commence!!! ⚙️ 👨🔧 |
Any updates for this one? |
I just commented because the last update is from 22 October |
Hi @dbeltrankyl, I will have a look at it today or tomorrow. One important thing: we just realized that with this approach we cannot serialize the |
Thanks Miguel!, there is no need for rush we're in the Autosubmit meeting revising PR, issues etc |
Yes, but is a very nice to have feature. I'm though not super happy about the serialization issue, I would say we should not merge until we have a solution for that, it will create problems in the future. |
In GitLab by @kinow on Oct 9, 2024, 14:46
Closes #11
cc @mandresm, @Hussam-Turjman. The code is not working yet, but just added a simple test, and the
provenance.py
from ESM tools. Tomorrow we can discuss briefly just where/how the provenance is hooked into the existing ruamel parsers/loaders (if we have time for that). Feel free to take over this MR and add/edit commits 👍