Skip to content

Commit fa32500

Browse files
eebassoax3lroelof-groenewald
authored
Fix typos in comments and docs (#4471)
* Fix typos and spelling * More typos * Typos 2023 Nov 27 * 2023 Nov 30 Update * Docs typos * Fix "arbitrary" * 2023 Dec 01 typos * Particles * ablastr - FieldSolver * Filter * Fluids * Docs + Tools * Change back to "lamda" * Fix typo Co-authored-by: Roelof Groenewald <40245517+roelof-groenewald@users.noreply.github.com> * Fix cylindrical --------- Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja> Co-authored-by: Roelof Groenewald <40245517+roelof-groenewald@users.noreply.github.com>
1 parent 0a39c8a commit fa32500

File tree

93 files changed

+159
-158
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

93 files changed

+159
-158
lines changed

CONTRIBUTING.rst

+1-1
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ A typical format is:
117117
118118
This is a short, 40-character title
119119
120-
After a newline, you can write arbitray paragraphs. You
120+
After a newline, you can write arbitrary paragraphs. You
121121
usually limit the lines to 70 characters, but if you don't, then
122122
nothing bad will happen.
123123

Docs/source/developers/checksum.rst

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ The checksum module is located in ``Regression/Checksum/``, and the benchmarks a
99

1010
For more details on the implementation, the Python files in ``Regression/Checksum/`` should be well documented.
1111

12-
From a user point of view, you should only need to use ``checksumAPI.py``. It contains Python functions that can be imported and used from an analysis Python script. It can also be executed directly as a Python script. Here are recipies for the main tasks related to checksum regression tests in WarpX CI.
12+
From a user point of view, you should only need to use ``checksumAPI.py``. It contains Python functions that can be imported and used from an analysis Python script. It can also be executed directly as a Python script. Here are recipes for the main tasks related to checksum regression tests in WarpX CI.
1313

1414
Include a checksum regression test in an analysis Python script
1515
---------------------------------------------------------------

Docs/source/developers/profiling.rst

+1-1
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ node, or without a workload management system.
247247
.. note::
248248

249249
To collect full statistics, Nsight-Compute reruns kernels,
250-
temporarilly saving device memory in host memory. This makes it
250+
temporarily saving device memory in host memory. This makes it
251251
slower than Nsight-Systems, so the provided script profiles only a single
252252
step of a single process. This is generally enough to extract relevant
253253
information.

Docs/source/developers/python.rst

+2-2
Original file line numberDiff line numberDiff line change
@@ -56,10 +56,10 @@ This is part of the standard - each of the PICMI classes call the method ``handl
5656
The main purpose is to process application specific keyword arguments (those that start with ``warpx_`` for example).
5757
These are then passed into the ``init`` methods.
5858
In the WarpX implementation, in the ``init``, each of the WarpX specific arguments are saved as attributes of the implementation
59-
class instancles.
59+
class instances.
6060

6161
It is in the second method, ``initialize_inputs``, where the PICMI input parameters are translated into WarpX input parameters.
62-
This method is called later during the intialization.
62+
This method is called later during the initialization.
6363
The prefix instances described above are all accessible in the implementation classes (via the ``pywarpx`` module).
6464
For each PICMI input quantity, the appropriate WarpX input parameters are set in the prefix classes.
6565
As needed, for example in the ``Species`` class, the dynamic prefix instances are created and the attributes set.

Docs/source/developers/repo_organization.rst

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ All WarpX header files need to be specified relative to the ``Source/`` director
4141
By default, in a ``MyName.cpp`` source file we do not include headers already included in ``MyName.H``. Besides this exception, if a function or a class
4242
is used in a source file, the header file containing its declaration must be included, unless the inclusion of a facade header is more appropriate. This is
4343
sometimes the case for AMReX headers. For instance ``AMReX_GpuLaunch.H`` is a façade header for ``AMReX_GpuLaunchFunctsC.H`` and ``AMReX_GpuLaunchFunctsG.H``, which
44-
contain respectively the CPU and the GPU implemetation of some methods, and which should not be included directly.
44+
contain respectively the CPU and the GPU implementation of some methods, and which should not be included directly.
4545
Whenever possible, forward declarations headers are included instead of the actual headers, in order to save compilation time (see dedicated section below). In WarpX forward
4646
declaration headers have the suffix ``*_fwd.H``, while in AMReX they have the suffix ``*Fwd.H``.
4747
The include order (see `PR #874 <https://github.com/ECP-WarpX/WarpX/pull/874#issuecomment-607038803>`__ and `PR #1947 <https://github.com/ECP-WarpX/WarpX/pull/1947>`__) and `proper quotation marks <https://gcc.gnu.org/onlinedocs/cpp/Include-Syntax.html>`__ are:

Docs/source/developers/testing.rst

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ For example, if you like to change the compiler to compilation to build on Nvidi
2525
branch = development
2626
cmakeSetupOpts = -DAMReX_ASSERTIONS=ON -DAMReX_TESTING=ON -DWarpX_COMPUTE=CUDA
2727
28-
We also support changing compilation options via the usual :ref:`build enviroment variables <building-cmake-envvars>`.
28+
We also support changing compilation options via the usual :ref:`build environment variables <building-cmake-envvars>`.
2929
For instance, compiling with ``clang++ -Werror`` would be:
3030

3131
.. code-block:: sh

Docs/source/developers/warning_logger.rst

+3-3
Original file line numberDiff line numberDiff line change
@@ -47,15 +47,15 @@ Each entry of warning list respects the following format:
4747
.. code-block:: sh
4848
4949
* --> [PRIORITY] [TOPIC] [raised COUNTER]
50-
* MULTILINE MESSAGGE
51-
* MULTILINE MESSAGGE
50+
* MULTILINE MESSAGE
51+
* MULTILINE MESSAGE
5252
* @ Raised by: WHICH_RANKS
5353
5454
where:
5555

5656
* ``[PRIORITY]`` can be ``[! ]`` (low priority), ``[!! ]`` (medium priority) or ``[!!!]`` (high priority). It indicates the importance of the warning.
5757
* ``[TOPIC]`` indicates which part of the code is concerned by the warning (e.g., particles, laser, parallelization...)
58-
* ``MULTILINE MESSAGGE`` is an arbitrary text message. It can span multiple-lines. Text is wrapped automatically.
58+
* ``MULTILINE MESSAGE`` is an arbitrary text message. It can span multiple-lines. Text is wrapped automatically.
5959
* ``COUNTER`` indicates the number of times the warning was raised **across all the MPI ranks**. This means that if we run WarpX with 2048 MPI ranks and each rank raises the same warning once, the displayed message will be ``[raised 2048 times]``. Possible values are ``once``, ``twice``, ``XX times``
6060
* ``WHICH_RANKS`` can be either ``ALL`` or a sequence of rank IDs. It is the list of the MPI ranks which have raised the warning message.
6161

Docs/source/glossary.rst

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ Abbreviations
1717
* **AMR:** adaptive mesh-refinement
1818
* **BC:** boundary condition (of a simulation)
1919
* **BCK:** `Benkler-Chavannes-Kuster <https://ieeexplore.ieee.org/document/1638381>`__ method, a stabilization technique for small cells in the electromagnetic solver
20-
* **BTD:** backtransformed diagnosics, a method to collect data for analysis from a *boosted frame* simulation
20+
* **BTD:** backtransformed diagnostics, a method to collect data for analysis from a *boosted frame* simulation
2121
* **CEX:** charge-exchange collisions
2222
* **CFL:** the Courant-Friedrichs-Lewy condition, a numerical parameter for the numerical convergence of PDE solvers
2323
* **CI:** continuous integration, automated tests that we perform before a proposed code-change is accepted; see PR

Docs/source/install/hpc/fugaku.rst

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ Use the following commands to download the WarpX source code and switch to the c
2424
git clone https://github.com/ECP-WarpX/WarpX.git $HOME/src/warpx
2525
2626
27-
Compiling WarpX on Fugaku is more pratical on a compute node. Use the following commands to acquire a compute node for one hour:
27+
Compiling WarpX on Fugaku is more practical on a compute node. Use the following commands to acquire a compute node for one hour:
2828

2929
.. code-block:: bash
3030

Docs/source/install/hpc/karolina.rst

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ If you are new to this system, **please see the following resources**:
1717
* `Filesystems <https://docs.it4i.cz/karolina/storage/>`__:
1818

1919
* ``$HOME``: per-user directory, use only for inputs, source and scripts; backed up (25GB default quota)
20-
* ``/scatch/``: `production directory <https://docs.it4i.cz/karolina/storage/#scratch-file-system>`__; very fast for parallel jobs (20TB default)
20+
* ``/scratch/``: `production directory <https://docs.it4i.cz/karolina/storage/#scratch-file-system>`__; very fast for parallel jobs (20TB default)
2121

2222

2323
.. _building-karolina-preparation:
@@ -143,7 +143,7 @@ Use the following :ref:`cmake commands <building-cmake>` to compile the applicat
143143
144144
Now, you can :ref:`submit Karolina compute jobs <running-cpp-karolina>` for WarpX :ref:`Python (PICMI) scripts <usage-picmi>` (:ref:`example scripts <usage-examples>`).
145145
Or, you can use the WarpX executables to submit Karolina jobs (:ref:`example inputs <usage-examples>`).
146-
For executables, you can reference their location in your :ref:`job script <running-cpp-karolina>` or copy them to a location in ``/scatch/``.
146+
For executables, you can reference their location in your :ref:`job script <running-cpp-karolina>` or copy them to a location in ``/scratch/``.
147147

148148

149149
.. _building-karolina-update:

Docs/source/latex_theory/AMR/AMR.tex

+1-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ \subsection{Electrostatic}
5353
% \caption{Snapshot from a 3D self-consistent simulation of the injector in the High Current Experiment shows the beam emerging from the source at low energy (blue) and being accelerated (green-yellow-orange) and transported in a four quadrupole front end. The automatic layout of the mesh refinement patches from a 2D axisymmetric simulation of the source area shows 2 levels of refinement, concentrating the finer meshes around the emitter (white curve surface) and the beam edge (dark blue).}
5454
% \label{fig:ESHCX}
5555
%\end{figure}
56-
%Automatic remeshing has been implemented in WarpX following the procedure described in \cite{Vaynim2005}, refining on criteria based on measures of local charge density magnitude and gradients. AMR WarpX simulations were applied to the modeling of the front end injector of the High Current Experiment (HCX) \cite{Prostprstab2005}, and provided the first numerically converged estimates of phase space beam distorsions, which directly affects beam quality \cite{Vaypop04}. Fig.~\ref{fig:ESHCX} shows snapshots from 2D axisymmetric simulation of the souce area illustrating the automatic placement of refined patches, and 3D simulation of the full injector showing the beam generation, acceleration and transport.
56+
%Automatic remeshing has been implemented in WarpX following the procedure described in \cite{Vaynim2005}, refining on criteria based on measures of local charge density magnitude and gradients. AMR WarpX simulations were applied to the modeling of the front end injector of the High Current Experiment (HCX) \cite{Prostprstab2005}, and provided the first numerically converged estimates of phase space beam distorsions, which directly affects beam quality \cite{Vaypop04}. Fig.~\ref{fig:ESHCX} shows snapshots from 2D axisymmetric simulation of the source area illustrating the automatic placement of refined patches, and 3D simulation of the full injector showing the beam generation, acceleration and transport.
5757

5858
\subsection{Electromagnetic}
5959
The method that is used for electrostatic mesh refinement is not directly applicable to electromagnetic calculations. As was shown in section 3.4 of \cite{Vayjcp01}, refinement schemes relying solely on interpolation between coarse and fine patches lead to the reflection with amplification of the short wavelength modes that fall below the cutoff of the Nyquist frequency of the coarse grid. Unless these modes are damped heavily or prevented from occurring at their source, they may affect particle motion and their effect can escalate if trapped within a patch, via multiple successive reflections with amplification.

Docs/source/theory/cold_fluid_model.rst

+1-1
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ Step 5: **Current and Charge Deposition**
9595

9696
Mesh refinement is not supported for the fluids.
9797

98-
The implemented MUSCL scheme has a simplifed slope averaging, see the extended writeup for details.
98+
The implemented MUSCL scheme has a simplified slope averaging, see the extended writeup for details.
9999

100100
More details on the precise implementation are available here, `WarpX_Cold_Rel_Fluids.pdf`_.
101101
.. _WarpX_Cold_Rel_Fluids.pdf: https://github.com/ECP-WarpX/WarpX/files/12886437/WarpX_Cold_Rel_Fluids.pdf

Docs/source/theory/kinetic_fluid_hybrid_model.rst

+1-1
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ Extrapolation step
134134

135135
Obtaining the E-field at timestep :math:`t=t_{n+1}` is a well documented issue for
136136
the hybrid model. Currently the approach in WarpX is to simply extrapolate
137-
:math:`\vec{J}_i` foward in time, using
137+
:math:`\vec{J}_i` forward in time, using
138138

139139
.. math::
140140

Docs/source/usage/how_to_run.rst

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ Where ``<run_directory>`` by the actual path to the run directory.
2525
-------------
2626

2727
If you installed warpX with a :ref:`package manager <install-users>`, a ``warpx``-prefixed executable will be available as a regular system command to you.
28-
Depending on the choosen build options, the name is suffixed with more details.
28+
Depending on the chosen build options, the name is suffixed with more details.
2929
Try it like this:
3030

3131
.. code-block:: bash

Docs/source/usage/parameters.rst

+6-6
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ Overall simulation parameters
155155
This only applies when warpx.do_electrostatic = labframe.
156156

157157
* ``warpx.self_fields_verbosity`` (`integer`, default: 2)
158-
The vebosity used for MLMG solver for space-charge fields calculation. Currently
158+
The verbosity used for MLMG solver for space-charge fields calculation. Currently
159159
MLMG solver looks for verbosity levels from 0-5. A higher number results in more
160160
verbose output.
161161

@@ -369,7 +369,7 @@ Domain Boundary Conditions
369369

370370
* ``Absorbing``: Particles leaving the boundary will be deleted.
371371

372-
* ``Periodic``: Particles leaving the boundary will re-enter from the opposite boundary. The field boundary condition must be consistenly set to periodic and both lower and upper boundaries must be periodic.
372+
* ``Periodic``: Particles leaving the boundary will re-enter from the opposite boundary. The field boundary condition must be consistently set to periodic and both lower and upper boundaries must be periodic.
373373

374374
* ``Reflecting``: Particles leaving the boundary are reflected from the boundary back into the domain.
375375
When ``boundary.reflect_all_velocities`` is false, the sign of only the normal velocity is changed, otherwise the sign of all velocities are changed.
@@ -861,7 +861,7 @@ Particle initialization
861861
``<species_name>.ux``, ``<species_name>.uy`` and ``<species_name>.uz``, the normalized
862862
momenta in the x, y and z direction respectively, which are all ``0.`` by default.
863863

864-
* ``uniform``: uniform probability distribution between a minumum and a maximum value.
864+
* ``uniform``: uniform probability distribution between a minimum and a maximum value.
865865
The x, y and z directions are sampled independently and the final momentum space is a cuboid.
866866
The parameters that control the minimum and maximum domain of the distribution
867867
are ``<species_name>.u<x,y,z>_min`` and ``<species_name>.u<x,y,z>_max`` in each
@@ -1190,7 +1190,7 @@ Cold Relativistic Fluid initialization
11901190
* ``fluids.species_names`` (`strings`, separated by spaces)
11911191
Defines the names of each fluid species. It is a required input to create and evolve fluid species using the cold relativistic fluid equations.
11921192
Most of the parameters described in the section "Particle initialization" can also be used to initialize fluid properties (e.g. initial density distribution).
1193-
For fluid-specific inputs we use `<fluid_pecies_name>` as a placeholder. Also see external fields
1193+
For fluid-specific inputs we use `<fluid_species_name>` as a placeholder. Also see external fields
11941194
for how to specify these for fluids as the function names differ.
11951195

11961196
.. _running-cpp-parameters-laser:
@@ -1726,7 +1726,7 @@ WarpX provides several particle collision models, using varying degrees of appro
17261726
total number of physical particle remains the same). This can improve
17271727
the statistics of the simulation, in the case where fusion reactions are very rare.
17281728
More specifically, in a fusion reaction between two macroparticles with weight ``w_1`` and ``w_2``,
1729-
the weight of the product macroparticles will be ``min(w_1,w_2)/fusion_multipler``.
1729+
the weight of the product macroparticles will be ``min(w_1,w_2)/fusion_multiplier``.
17301730
(And the weights of the reactant macroparticles are reduced correspondingly after the reaction.)
17311731
See `Higginson et al. (JCP 388, 439-453, 2019) <https://doi.org/10.1016/j.jcp.2019.03.020>`__
17321732
for more details. The default value of ``fusion_multiplier`` is 1.
@@ -2299,7 +2299,7 @@ Additional parameters
22992299

23002300
* ``warpx.shared_tilesize`` (list of `int`) optional (default `6 6 8` in 3D; `14 14` in 2D; `1s` otherwise)
23012301
Used to tune performance when ``do_shared_mem_current_deposition`` or
2302-
``do_shared_mem_charge_depostion`` is enabled. ``shared_tilesize`` is the
2302+
``do_shared_mem_charge_deposition`` is enabled. ``shared_tilesize`` is the
23032303
size of the temporary buffer allocated in shared memory for a threadblock.
23042304
A larger tilesize requires more shared memory, but gives more work to each
23052305
threadblock, which can lead to higher occupancy, and allows for more

Examples/Physics_applications/laser_acceleration/analysis_1d_fluids.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ def odefcn(phi, xi, kp, a0, c, tau, xi_0, lambda_laser):
9090
# Remove the ions
9191
rho_th = rho_th - e*n0
9292

93-
# Dicate which region to compare solutions over
93+
# Dictate which region to compare solutions over
9494
# (Currently this is the full domain)
9595
min_i = 0
9696
max_i = 10240

Examples/Physics_applications/laser_acceleration/analysis_1d_fluids_boosted.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ def odefcn(phi, xi, kp, a0, c, tau, xi_0, lambda_laser):
9090
# Remove the ions
9191
rho_th = rho_th - e*n0
9292

93-
# Dicate which region to compare solutions over (cuttoff 0's from BTD extra)
93+
# Dictate which region to compare solutions over (cuttoff 0's from BTD extra)
9494
min_i = 200
9595
max_i = 4864
9696

Examples/Physics_applications/laser_acceleration/analysis_refined_injection.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
n_move = 192
4444

4545
# ref ratio = 2 1
46-
# Refined only transversly. Longitudinal spacing between particles in each stream is the same in both coarse and fine regions
46+
# Refined only transversely. Longitudinal spacing between particles in each stream is the same in both coarse and fine regions
4747
rr_longitudinal = 1
4848

4949
np_expected = (n_coarse + n_fine*rr_longitudinal)*(n_0 + n_move)

Examples/Tests/field_probe/analysis_field_probe.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@
99
"""
1010
This script tests the accuracy of the FieldProbe diagnostic by observing a plane
1111
wave undergoing single slit diffraction. The input file inputs_2d is used. This
12-
file defines the simulation box, laser pulse, embeded boundary with single slit,
12+
file defines the simulation box, laser pulse, embedded boundary with single slit,
1313
and line of detector points. The plane wave initializes near the negative Z end
14-
of the simulation box. The wave interacts with the embeded boundary at Z=0. The
14+
of the simulation box. The wave interacts with the embedded boundary at Z=0. The
1515
wave undergoes diffraction at the slit. The electromagnetic flux is calculated
1616
at the line detector which is placed perpendicular to Z beyond the slit. This
1717
test will check if the detected EM flux matches expected values,
@@ -39,7 +39,7 @@ def I_envelope (x, lam = 0.2e-6, a = 0.3e-6, D = 1.7e-6):
3939
arg = np.pi * a / lam * np.sin(np.arctan(x / D))
4040
return np.sinc( arg / np.pi )**2
4141

42-
# Count non-outlyer values away from simulation boundaries
42+
# Count non-outlier values away from simulation boundaries
4343
counter = np.arange(60, 140, 2)
4444

4545
# Count average error from expected values

Examples/Tests/flux_injection/analysis_flux_injection_3d.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
1818
After the particles are emitted with flux injection, this script produces
1919
histograms of the velocity distribution and compares it with the expected
20-
velocity distibution (Gaussian or Gaussian-flux depending on the direction
20+
velocity distribution (Gaussian or Gaussian-flux depending on the direction
2121
of space)
2222
"""
2323
import os

Examples/Tests/ion_stopping/analysis_ion_stopping.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ def stopping_from_ions(dt, ni, Ti, mi, Zi, Zb, ion_mass, ion_energy):
7373
ion_energy = (f1)**(2./3.)/e
7474
return ion_energy
7575

76-
# Fetch background parameters and inital particle data
76+
# Fetch background parameters and initial particle data
7777
ds0 = yt.load(f'{prefix}{len(last_it)*"0"}')
7878
ad0 = ds0.all_data()
7979

Examples/Tests/nuclear_fusion/analysis_proton_boron_fusion.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -521,7 +521,7 @@ def check_initial_energy2(data):
521521

522522
# Loop over all slices (i.e. cells in the z direction)
523523
for slice_number in range(1, size_z):
524-
## For simplicity, all the calculations in this functino are done nonrelativistically
524+
## For simplicity, all the calculations in this function are done nonrelativistically
525525
## Proton kinetic energy in the lab frame before fusion
526526
E_proton_nonrelativistic = Energy_step*slice_number**2
527527
## Corresponding square norm of proton momentum

Examples/Tests/ohm_solver_ion_Landau_damping/PICMI_inputs.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
#
33
# --- Test script for the kinetic-fluid hybrid model in WarpX wherein ions are
44
# --- treated as kinetic particles and electrons as an isothermal, inertialess
5-
# --- background fluid. The script simulates ion Landau damping as descibed
5+
# --- background fluid. The script simulates ion Landau damping as described
66
# --- in section 4.5 of Munoz et al. (2018).
77

88
import argparse

0 commit comments

Comments
 (0)