fix: compare result to IOTHUB_CLIENT_CONNECTION_AUTHENTICATED #2666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This appears to be a theoretical bug. The sample code is comparing two values of disparate enum types. The enumerators that are being used in the comparison have the same values (and so the comparison behavior is valid), but other uses of this enumeration type suggest that this was a typo.
Nostracodus
requested review from
ewertons,
RLeclair and
vaavva
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devdocfolder and added or modified requirements.mainbranch.mainbranch prior to submission and re-merged as needed after I took any feedback.Description of the problem
I work on Microsoft's Visual C++ compiler. This repo is one of the repos we regularly build as part of our outer dev loop. A recently implemented warning detected this instance of implicit enum conversion (comparing two values of different enum types).
This appears to be a theoretical bug. The enumerators that are being used in the comparison have the same values (and so the comparison behavior is unchanged), but other uses of this enumeration type in the repo suggest that this coercion was unintentional.
Description of the solution
I modified the comparison to use the
IOTHUB_CLIENT_CONNECTION_AUTHENTICATEDenumerator, as other instances of the repo seem to do.