Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new groupByVariables to Configure Rate Limit Custom Rules #30954

Open
yaarark opened this issue Mar 5, 2025 · 1 comment
Open

Add new groupByVariables to Configure Rate Limit Custom Rules #30954

yaarark opened this issue Mar 5, 2025 · 1 comment
Assignees
@necusjz
Labels
Auto-Assign Auto assign by bot Azure CLI Team The command of the issue is owned by Azure CLI team customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request Network az network vnet/lb/nic/dns/etc...
Milestone
Backlog

Comments

@yaarark
Copy link

yaarark commented Mar 5, 2025

Related command
Add new groupByVariables to Configure Rate Limit Custom Rules https://learn.microsoft.com/en-us/azure/web-application-firewall/ag/rate-limiting-configure?tabs=cli.
GeoLocationXffHeader, ClientAddrXffHeader.
For example:

az network application-gateway waf-policy custom-rule create --policy-name ExamplePolicy --resource-group ExampleRG --action Block --name ClientIPRateLimitRule --priority 90 --rule-type RateLimitRule --rate-limit-threshold 100 --group-by-user-session '[{'"groupByVariables"':[{'"variableName"':'"ClientAddrXffHeader"'}]}]'

az network application-gateway waf-policy custom-rule create --policy-name ExamplePolicy --resource-group ExampleRG --action Block --name ClientIPRateLimitRule --priority 90 --rule-type RateLimitRule --rate-limit-threshold 100 --group-by-user-session '[{'"groupByVariables"':[{'"variableName"':'"GeoLocationXffHeader"'}]}]'

Describe the solution you'd like

Add two variableName options to groupByVariables. GeoLocationXffHeader, ClientAddrXffHeader.

Additional context

Code changes will be part of NRP 187 and Appgw changes is part of 30.0 release. Swagger changes will be part of next release.
@yonzhan
Copy link
Collaborator

yonzhan commented Mar 5, 2025

Thank you for opening this issue, we will look into it.

@microsoft-github-policy-service microsoft-github-policy-service bot added customer-reported Issues that are reported by GitHub users external to the Azure organization. Network az network vnet/lb/nic/dns/etc... labels Mar 5, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added Auto-Assign Auto assign by bot Azure CLI Team The command of the issue is owned by Azure CLI team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Mar 5, 2025
@yonzhan yonzhan added this to the Backlog milestone Mar 5, 2025
@yonzhan yonzhan added feature-request and removed question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@necusjz necusjz

Labels
Auto-Assign Auto assign by bot Azure CLI Team The command of the issue is owned by Azure CLI team customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request Network az network vnet/lb/nic/dns/etc...
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@necusjz @yonzhan @yaarark