Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Internet Banner #63

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

No Internet Banner #63

wants to merge 10 commits into from

Conversation

Heliophist
Copy link
Contributor

Added NoInternetBanner.js to components folder.
Modified app.js to scan for wifi/internet presence.
Installed some stuff from react native community netinfo.

Added NoInternetBanner.js to components folder.
Modified app.js to scan for wifi/internet presence.
Copy link

github-actions bot commented Jul 30, 2024

🚀 Expo preview is ready!

  • Project → audacity-music-club
  • Platforms → android, ios
  • Runtime Version → 1.0.0
  • More info

Learn more about 𝝠 Expo Github Action

Used prettier
@TenType TenType linked an issue Jul 30, 2024 that may be closed by this pull request
Copy link
Member

@TenType TenType left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iOS: White gap at the top of the screen
Android: No gap but the banner is not visible

I think the issues should be gone.
@TenType
Copy link
Member

TenType commented Aug 10, 2024

Not resolved - still has the gap on iOS
image

@Heliophist
Copy link
Contributor Author

On my end, the code works I can send a screenshot.
However, I have had to merge mine with the updated app.js, so things may be a little messy,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No Internet banner
2 participants