Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub ACtions pipeline: ensure Cypress component tests run correctly #1828

Merged
merged 4 commits into from
Feb 20, 2025

Conversation

Keikonichi
Copy link
Collaborator

Description

The following adjustments were made:

  • Fixed the syntax of the step responsible for running component tests.
  • Ensured that the cypress-run job includes both E2E and component tests.
  • Adjustments to make sure the workflow is correctly identified and all tests are executed.

This change ensures that the CI/CD pipeline continues to function properly and that component tests are executed as expected.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Testing

Steps to validate the tests:

  1. Ran the component tests locally using:

yarn cypress run --component

  1. Verified that all tests passed without errors.
  2. Pushed the changes to GitHub and monitored the execution in GitHub Actions.
  3. Confirmed that the cypress-run job successfully executed the component tests.

Developer Checklist

General

  • Code is appropriately commented, particularly in hard-to-understand areas
  • Repository documentation has been updated (Readme.md) with additional steps required for a local environment setup.
  • No console.log or related logging is added.
  • No code is repeated/duplicated in violation of DRY. The exception to this is for new (MVP/Prototype) functionality where the abstraction layer may not be clear (comments should be added to explain the violation of DRY in these scenarios).
  • Documented with TSDoc all library and controller new functions

Tests

  • All existing unit and end to end tests pass across all services

Merge Request Review Checklist

  • High risk and core workflows have been tested and verified in a local environment.

@Keikonichi Keikonichi self-assigned this Feb 19, 2025
@Keikonichi Keikonichi added bug Something isn't working tech labels Feb 19, 2025
@Keikonichi Keikonichi marked this pull request as ready for review February 19, 2025 20:13
@Keikonichi Keikonichi removed the request for review from giovannirossini February 19, 2025 20:14
@thesocialdev thesocialdev merged commit aad77a1 into stage Feb 20, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tech
Projects
Status: QA
Development

Successfully merging this pull request may close these issues.

2 participants