Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Personality card break on smaller screens on search page #1823

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

lucaslobatob
Copy link
Collaborator

Description

SearchResults.tsx: Updated Grid container styles to prevent component breakage in mobile environments by setting flexWrap: "nowrap" to maintain elements on the same line and adding a 10px gap for consistent spacing.

Fixes #1709

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing

1. Be in a "small" environment with less than 768px, such as mobile;
2. Be logged in to the platform;
3. Enter the search page, if you are local http://localhost:3000/search;
4. Search for an existing personality.

Screenshot from 2025-02-18 12-05-41

Test Video

Screencast.from.18-02-2025.12.03.55.webm

Developer Checklist

General

  • No console.log or related logging is added.

Frontend Changes

  • No new styling is added through CSS files (Unless it's a bugfix/hotfix)
  • All types are added correctly

Tests

  • All existing unit and end to end tests pass across all services
  • Unit and end to end tests have been added to ensure backend APIs behave as expected

Merge Request Review Checklist

  • An issue is linked to this PR and these changes meet the requirements outlined in the linked issue(s)
  • High risk and core workflows have been tested and verified in a local environment.
  • Enhancements or opportunities to improve performance, stability, security or code readability have been noted and documented in JIRA issues if not being addressed.
  • Any dependent changes have been merged and published in downstream modules
  • Changes to multiple services can be deployed in parallel and independently. If not, changes should be broken out into separate merge requests and deployed in order.

@thesocialdev
Copy link
Collaborator

@lucaslobatob the pipeline is broken and should be a quick-fix:

Error: This request has been automatically failed because it uses a deprecated version of `actions/cache: v4.0.2`. Please update your workflow to use v3/v4 of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down

@thesocialdev thesocialdev merged commit b945f51 into stage Feb 19, 2025
2 checks passed
@thesocialdev thesocialdev deleted the 1709-bug-personality-card-break-on-searchpage branch February 19, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: QA
Development

Successfully merging this pull request may close these issues.

Bug: Personality card break on smaller screens on search page
2 participants