Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add waiting state #78

Merged
merged 4 commits into from
Feb 10, 2025
Merged

feat: add waiting state #78

merged 4 commits into from
Feb 10, 2025

Conversation

lotharking
Copy link
Contributor

@lotharking lotharking commented Feb 7, 2025 •
edited
Loading

Summary

Related issue: 2060-io/unic.id-generic-verifier-dts#9

Changes

Related Issues

Testing

Checklist

  • I have commented on my code, especially in areas that are hard to understand.
  • I have added only changes relevant to the issue in question.
  • I have added tests to confirm that my fix is effective or that my feature works as intended.
  • I have modified existing tests as needed to accommodate my changes.
  • I have flagged specific areas for further review, if necessary.
  • I have updated the documentation where necessary.

@lotharking lotharking requested a review from genaris February 7, 2025 05:54
@lotharking lotharking marked this pull request as ready for review February 7, 2025 05:54
genaris
genaris approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@genaris genaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very elegant and simple solution! Let's see how this new feature improves the UX of the verifier.

lotharking and others added 3 commits February 10, 2025 09:11
@lotharking lotharking merged commit 3b69e6b into main Feb 10, 2025
2 checks passed
@lotharking lotharking deleted the feat/add-waiting-state branch February 10, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@genaris genaris genaris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lotharking @genaris